Replace raw pointers to GC allocated objects by members in stack allocated objects.

Source/bindings/v8/Dictionary.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 41 matching lines @@
 class MediaKeyError;
 class Notification;
 class SpeechRecognitionError;
 class SpeechRecognitionResult;
 class SpeechRecognitionResultList;
 class Storage;
 class TrackBase;
 class VoidCallback;
 
 class Dictionary {
 public:

[wibling-chromium, 2014/03/24 08:18:37]

Can't we add STACK_ALLOCATED() here?

[zerny-chromium, 2014/03/24 08:32:28]

Good point. I'll add that and remove the explicit new below.

[zerny-chromium, 2014/03/24 10:08:24]

QQ: it needs to be ALLOW_ONLY_INLINE_ALLOCATION().

     Dictionary();
     Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate*);
     ~Dictionary();
 
     Dictionary& operator=(const Dictionary&);
 
     bool isObject() const;
     bool isUndefinedOrNull() const;
 
     bool get(const String&, bool&) const;
@@ skipping 10 matching lines @@
     bool get(const String&, unsigned long long&) const;
     bool get(const String&, RefPtr<DOMWindow>&) const;
     bool get(const String&, RefPtrWillBeMember<Storage>&) const;
     bool get(const String&, MessagePortArray&) const;
     bool get(const String&, RefPtr<Uint8Array>&) const;
     bool get(const String&, RefPtr<ArrayBufferView>&) const;
     bool get(const String&, RefPtr<MIDIPort>&) const;
     bool get(const String&, RefPtr<MediaKeyError>&) const;
     bool get(const String&, RefPtr<TrackBase>&) const;
     bool get(const String&, RefPtr<SpeechRecognitionError>&) const;
-    bool get(const String&, RefPtrWillBeRawPtr<SpeechRecognitionResult>&) const;
-    bool get(const String&, RefPtrWillBeRawPtr<SpeechRecognitionResultList>&) const;
+    bool get(const String&, RefPtrWillBeMember<SpeechRecognitionResult>&) const;
+    bool get(const String&, RefPtrWillBeMember<SpeechRecognitionResultList>&) const;
     bool get(const String&, RefPtrWillBeMember<Gamepad>&) const;
     bool get(const String&, RefPtr<MediaStream>&) const;
     bool get(const String&, RefPtr<EventTarget>&) const;
     bool get(const String&, HashSet<AtomicString>&) const;
     bool get(const String&, Dictionary&) const;
     bool get(const String&, Vector<String>&) const;
     bool get(const String&, ArrayValue&) const;
-    bool get(const String&, RefPtrWillBeRawPtr<DOMError>&) const;
+    bool get(const String&, RefPtrWillBeMember<DOMError>&) const;
     bool get(const String&, OwnPtr<VoidCallback>&) const;
     bool get(const String&, v8::Local<v8::Value>&) const;
 
     class ConversionContext {
     public:
         ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState)
             : m_interfaceName(interfaceName)
             , m_methodName(methodName)
             , m_exceptionState(exceptionState)
             , m_dirty(true)
@@ skipping 232 matching lines @@
     if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
         return true;
 
     context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have a " + context.typeName() + " type."));
     return false;
 }
 
 }
 
 #endif // Dictionary_h