Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: Source/bindings/v8/Dictionary.cpp

Issue 208313010: Replace raw pointers to GC allocated objects by members in stack allocated objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 bool Dictionary::get(const String& key, RefPtr<SpeechRecognitionError>& value) c onst 483 bool Dictionary::get(const String& key, RefPtr<SpeechRecognitionError>& value) c onst
484 { 484 {
485 v8::Local<v8::Value> v8Value; 485 v8::Local<v8::Value> v8Value;
486 if (!getKey(key, v8Value)) 486 if (!getKey(key, v8Value))
487 return false; 487 return false;
488 488
489 value = V8SpeechRecognitionError::toNativeWithTypeCheck(m_isolate, v8Value); 489 value = V8SpeechRecognitionError::toNativeWithTypeCheck(m_isolate, v8Value);
490 return true; 490 return true;
491 } 491 }
492 492
493 bool Dictionary::get(const String& key, RefPtrWillBeRawPtr<SpeechRecognitionResu lt>& value) const 493 bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionResu lt>& value) const
494 { 494 {
495 v8::Local<v8::Value> v8Value; 495 v8::Local<v8::Value> v8Value;
496 if (!getKey(key, v8Value)) 496 if (!getKey(key, v8Value))
497 return false; 497 return false;
498 498
499 value = V8SpeechRecognitionResult::toNativeWithTypeCheck(m_isolate, v8Value) ; 499 value = V8SpeechRecognitionResult::toNativeWithTypeCheck(m_isolate, v8Value) ;
500 return true; 500 return true;
501 } 501 }
502 502
503 bool Dictionary::get(const String& key, RefPtrWillBeRawPtr<SpeechRecognitionResu ltList>& value) const 503 bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionResu ltList>& value) const
504 { 504 {
505 v8::Local<v8::Value> v8Value; 505 v8::Local<v8::Value> v8Value;
506 if (!getKey(key, v8Value)) 506 if (!getKey(key, v8Value))
507 return false; 507 return false;
508 508
509 value = V8SpeechRecognitionResultList::toNativeWithTypeCheck(m_isolate, v8Va lue); 509 value = V8SpeechRecognitionResultList::toNativeWithTypeCheck(m_isolate, v8Va lue);
510 return true; 510 return true;
511 } 511 }
512 512
513 bool Dictionary::get(const String& key, RefPtrWillBeMember<Gamepad>& value) cons t 513 bool Dictionary::get(const String& key, RefPtrWillBeMember<Gamepad>& value) cons t
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 return true; 653 return true;
654 654
655 if (!v8Value->IsArray()) { 655 if (!v8Value->IsArray()) {
656 context.throwTypeError(ExceptionMessages::notASequenceTypeProperty(key)) ; 656 context.throwTypeError(ExceptionMessages::notASequenceTypeProperty(key)) ;
657 return false; 657 return false;
658 } 658 }
659 659
660 return get(key, value); 660 return get(key, value);
661 } 661 }
662 662
663 bool Dictionary::get(const String& key, RefPtrWillBeRawPtr<DOMError>& value) con st 663 bool Dictionary::get(const String& key, RefPtrWillBeMember<DOMError>& value) con st
664 { 664 {
665 v8::Local<v8::Value> v8Value; 665 v8::Local<v8::Value> v8Value;
666 if (!getKey(key, v8Value)) 666 if (!getKey(key, v8Value))
667 return false; 667 return false;
668 668
669 value = V8DOMError::toNativeWithTypeCheck(m_isolate, v8Value); 669 value = V8DOMError::toNativeWithTypeCheck(m_isolate, v8Value);
670 return true; 670 return true;
671 } 671 }
672 672
673 bool Dictionary::get(const String& key, OwnPtr<VoidCallback>& value) const 673 bool Dictionary::get(const String& key, OwnPtr<VoidCallback>& value) const
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 751
752 return *this; 752 return *this;
753 } 753 }
754 754
755 void Dictionary::ConversionContext::throwTypeError(const String& detail) 755 void Dictionary::ConversionContext::throwTypeError(const String& detail)
756 { 756 {
757 exceptionState().throwTypeError(detail); 757 exceptionState().throwTypeError(detail);
758 } 758 }
759 759
760 } // namespace WebCore 760 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698