Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 2083103002: Remove some uses of STL map. (Closed)

Created:
4 years, 6 months ago by zra
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove some uses of STL map. This CL removes the use of STL map from freelist.cc by adding MallocDirectChainedHashMap in hash_map.h and adding an iterator for BaseDirectChainedHashMap there. It also removes a use of STL map from hash_table.h that was dead code. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/e933f28a18c7edb468390beafb4ae566dd0542dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -208 lines) Patch
M runtime/vm/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/freelist.cc View 2 chunks +39 lines, -13 lines 0 comments Download
M runtime/vm/hash_map.h View 9 chunks +155 lines, -39 lines 0 comments Download
M runtime/vm/hash_map_test.cc View 1 chunk +86 lines, -7 lines 0 comments Download
M runtime/vm/hash_table.h View 5 chunks +1 line, -102 lines 0 comments Download
M runtime/vm/hash_table_test.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/redundancy_elimination.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/source_report.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/zone.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zra
4 years, 6 months ago (2016-06-21 20:53:31 UTC) #2
Cutch
lgtm
4 years, 6 months ago (2016-06-21 21:06:25 UTC) #3
Florian Schneider
drive-by question: do you see any improvement in binary size with this CL?
4 years, 6 months ago (2016-06-21 21:09:22 UTC) #5
zra
On 2016/06/21 21:09:22, Florian Schneider wrote: > drive-by question: do you see any improvement in ...
4 years, 6 months ago (2016-06-21 22:03:45 UTC) #6
zra
4 years, 6 months ago (2016-06-22 15:32:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e933f28a18c7edb468390beafb4ae566dd0542dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698