Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain.

Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain.

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686
Committed: https://crrev.com/44febce5c4911c03a7975273235fce6e9cacd16d
Cr-Commit-Position: refs/heads/master@{#401532}

[Dirk Pranke, 2016-06-22 01:34:17]

Description was changed from

==========
Move the cros_* GN args to a .gni file.

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them.

R=mcgrathr@chromium.org, llozano@chromium.org
BUG=621686
==========

to

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org
BUG=621686
==========

[Dirk Pranke, 2016-06-22 01:36:12]

Patchset #1 (id:1) has been deleted

[Dirk Pranke, 2016-06-22 01:39:07]

dpranke@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Dirk Pranke, 2016-06-22 01:39:08]

This patch is needed before we can land
https://codereview.chromium.org/2085683004/ ; the combination of the two should
fix the bug.

[Dirk Pranke, 2016-06-22 01:39:22]

Description was changed from

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org
BUG=621686
==========

to

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686
==========

[Dirk Pranke, 2016-06-22 01:45:43]

Description was changed from

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686
==========

to

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain.

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686
==========

[bradnelson, 2016-06-22 03:46:10]

lgtm

[Dirk Pranke, 2016-06-22 04:02:39]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 04:03:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083063003/20001

[commit-bot: I haz the power, 2016-06-22 04:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 04:09:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Roland McGrath, 2016-06-22 19:22:21]

LGTM.  The try failures are one of the stupid gn limitations that have annoyed
me before.  Perhaps you'll be inspired to actually fix gn instead of just using
some silly workaround like I always did for these cases.

[Dirk Pranke, 2016-06-22 21:19:23]

On 2016/06/22 19:22:21, Roland McGrath wrote:
> LGTM.  The try failures are one of the stupid gn limitations that have annoyed
> me before.  Perhaps you'll be inspired to actually fix gn instead of just
using
> some silly workaround like I always did for these cases.

I think those failures are actually kinda real and something needs to be fixed,
but, yeah, the scoping rules are weird in this case.

[Dirk Pranke, 2016-06-23 02:41:34]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-06-23 02:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org, mcgrathr@chromium.org
Link to the patchset: https://codereview.chromium.org/2083063003/#ps80001
(title: "import needed declare_args(), fix toolchain_os")

[commit-bot: I haz the power, 2016-06-23 02:41:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083063003/80001

[commit-bot: I haz the power, 2016-06-23 03:36:21]

Description was changed from

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain.

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686
==========

to

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain.

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686
==========

[commit-bot: I haz the power, 2016-06-23 03:36:23]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-06-23 03:38:58]

Description was changed from

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain.

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686
==========

to

==========
Move the cros_* GN args to a .gni file and add a bootstrap cros toolchain.

This moves the cros_* GN args from //build/toolchain/cros/BUILD.gn
to //build/toolchain/cros_toolchain.gni so that files in other
places (specifically in native_client/src/trusted/service_runtime/linux)
can have access to them, and adds the nacl_bootstrap toolchain to
//build/toolchain/cros so that it is kept consistent with the target
toolchains.

R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
BUG=621686

Committed: https://crrev.com/44febce5c4911c03a7975273235fce6e9cacd16d
Cr-Commit-Position: refs/heads/master@{#401532}
==========

[commit-bot: I haz the power, 2016-06-23 03:38:59]

Patchset 4 (id:??) landed as
https://crrev.com/44febce5c4911c03a7975273235fce6e9cacd16d
Cr-Commit-Position: refs/heads/master@{#401532}