Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2083063002: Rietveld git cl status: ignore CQ dry run and generated messages. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 6 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rietveld git cl status: ignore CQ dry run and generated messages. R=sergiyb@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d2c7a3d9ab7c0694b1cbd6ffc519618b92330ed

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M git_cl.py View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tandrii(chromium)
4 years, 6 months ago (2016-06-21 17:32:27 UTC) #1
Sergiy Byelozyorov
lgtm It is sad to see that CQ specific messages are being added to depot_tools, ...
4 years, 6 months ago (2016-06-22 04:10:46 UTC) #2
tandrii(chromium)
https://codereview.chromium.org/2083063002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2083063002/diff/1/git_cl.py#newcode1716 git_cl.py:1716: # This messages always follows prior messages from CQ, ...
4 years, 6 months ago (2016-06-22 10:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083063002/20001
4 years, 6 months ago (2016-06-22 10:39:11 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 10:42:49 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d2c7a3d9ab7c0...

Powered by Google App Engine
This is Rietveld 408576698