Issue 208303002: Fixed resize filter (with test)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208303002: Fixed resize filter (with test) (Closed)

Created:
6 years, 9 months ago by sugoi1

Modified:
6 years, 9 months ago

Reviewers:
Stephen White, senorblanco

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fixed double offset in resize filter The fix is trivial, simply remove the extra offset I added another case to the resizeimagefilter gm and made it so that it looks exactly like the one next to it, so that failure is easy to detect visually. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13892

Patch Set 1 #

Patch Set 2 : Added entry to ignore-tests #

Total comments: 1

Patch Set 3 : update to ToT #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -4 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gm/resizeimagefilter.cpp	View		5 chunks	+30 lines, -3 lines	0 comments	Download
M	src/effects/SkResizeImageFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen White

LGTM https://codereview.chromium.org/208303002/diff/20001/expectations/gm/ignored-tests.txt File expectations/gm/ignored-tests.txt (right): https://codereview.chromium.org/208303002/diff/20001/expectations/gm/ignored-tests.txt#newcode64 expectations/gm/ignored-tests.txt:64: # sugoi: https://codereview.chromium.org/208303002/ I think you'll have to ...

6 years, 9 months ago (2014-03-21 15:07:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/208303002/40001

6 years, 9 months ago (2014-03-21 15:14:51 UTC) #4

Message was sent while issue was closed.

Change committed as 13892

Expand Messages | Collapse Messages