Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2083023004: [ash-md] Eliminates 1px border around overview mode shield (Closed)

Created:
4 years, 6 months ago by varkha
Modified:
4 years, 6 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Eliminates 1px border around overview mode shield BUG=622390 Committed: https://crrev.com/e6d6671a1c6ba2ef89722527aae43ad4998c1c0b Cr-Commit-Position: refs/heads/master@{#401498}

Patch Set 1 #

Patch Set 2 : [ash-md] Eliminates 1px border around overview mode shield #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ash/common/wm/overview/window_grid.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083023004/1
4 years, 6 months ago (2016-06-22 20:44:11 UTC) #2
varkha
tdanderson@, this rounding error was causing a 1px border that was not painted with fill ...
4 years, 6 months ago (2016-06-22 20:44:33 UTC) #4
tdanderson
On 2016/06/22 20:44:33, varkha wrote: > tdanderson@, this rounding error was causing a 1px border ...
4 years, 6 months ago (2016-06-22 20:47:30 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/243729)
4 years, 6 months ago (2016-06-22 22:39:58 UTC) #7
varkha
+sky@ for OWNERS now that wm/overview has moved to common/wm/overview.
4 years, 6 months ago (2016-06-22 22:49:24 UTC) #9
varkha
Once https://codereview.chromium.org/2092613002/ lands no need to have sky@ on this, so sky@ to cc:.
4 years, 6 months ago (2016-06-22 23:17:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083023004/20001
4 years, 6 months ago (2016-06-23 00:27:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 01:20:36 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 01:23:32 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6d6671a1c6ba2ef89722527aae43ad4998c1c0b
Cr-Commit-Position: refs/heads/master@{#401498}

Powered by Google App Engine
This is Rietveld 408576698