Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2083023002: Stop PingLoader's cancellation timer early. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop PingLoader's cancellation timer early. If the ping completed, stop the loader's cancellation timer. R=japhet BUG= Committed: https://crrev.com/d93996ca8b2859d64ae4f47ee053d2a372642974 Cr-Commit-Position: refs/heads/master@{#401068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look. No need to wait for the GC to stop the timer/task.
4 years, 6 months ago (2016-06-21 14:36:56 UTC) #2
Nate Chapin
lgtm
4 years, 6 months ago (2016-06-21 16:15:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083023002/1
4 years, 6 months ago (2016-06-21 17:37:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 19:11:07 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d93996ca8b2859d64ae4f47ee053d2a372642974 Cr-Commit-Position: refs/heads/master@{#401068}
4 years, 6 months ago (2016-06-21 19:15:01 UTC) #10
tyoshino (SeeGerritForStatus)
4 years, 6 months ago (2016-06-22 03:31:05 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698