[turbofan] Address the useless overflow bit materialization.

src/compiler/simplified-operator.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/simplified-operator.h"
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 #include "src/types.h"
@@ skipping 290 matching lines @@
   V(StringLessThan, Operator::kNoProperties, 2)            \
   V(StringLessThanOrEqual, Operator::kNoProperties, 2)
 
 #define SPECULATIVE_BINOP_LIST(V) \
   V(SpeculativeNumberAdd)         \
   V(SpeculativeNumberSubtract)    \
   V(SpeculativeNumberDivide)      \
   V(SpeculativeNumberMultiply)    \
   V(SpeculativeNumberModulus)
 
-#define CHECKED_OP_LIST(V) \
-  V(CheckTaggedPointer)    \
-  V(CheckTaggedSigned)     \
-  V(CheckedUint32ToInt32)  \
-  V(CheckedFloat64ToInt32) \
-  V(CheckedTaggedToInt32)  \
-  V(CheckedTaggedToFloat64)
+#define CHECKED_OP_LIST(V)    \
+  V(CheckTaggedPointer, 1)    \
+  V(CheckTaggedSigned, 1)     \
+  V(CheckedInt32Add, 2)       \
+  V(CheckedInt32Sub, 2)       \
+  V(CheckedUint32ToInt32, 1)  \
+  V(CheckedFloat64ToInt32, 1) \
+  V(CheckedTaggedToInt32, 1)  \
+  V(CheckedTaggedToFloat64, 1)
 
 struct SimplifiedOperatorGlobalCache final {
 #define PURE(Name, properties, input_count)                                \
   struct Name##Operator final : public Operator {                          \
     Name##Operator()                                                       \
         : Operator(IrOpcode::k##Name, Operator::kPure | properties, #Name, \
                    input_count, 0, 0, 1, 0, 0) {}                          \
   };                                                                       \
   Name##Operator k##Name;
   PURE_OP_LIST(PURE)
 #undef PURE
 
-#define CHECKED(Name)                                                        \
-  struct Name##Operator final : public Operator {                            \
-    Name##Operator()                                                         \
-        : Operator(IrOpcode::k##Name,                                        \
-                   Operator::kFoldable | Operator::kNoThrow, #Name, 1, 1, 1, \
-                   1, 1, 0) {}                                               \
-  };                                                                         \
+#define CHECKED(Name, value_input_count)                            \
+  struct Name##Operator final : public Operator {                   \
+    Name##Operator()                                                \
+        : Operator(IrOpcode::k##Name,                               \
+                   Operator::kFoldable | Operator::kNoThrow, #Name, \
+                   value_input_count, 1, 1, 1, 1, 0) {}             \
+  };                                                                \
   Name##Operator k##Name;
   CHECKED_OP_LIST(CHECKED)
 #undef CHECKED
 
   template <CheckFloat64HoleMode kMode>
-  struct CheckFloat64HoleNaNOperatortor final
+  struct CheckFloat64HoleNaNOperator final
       : public Operator1<CheckFloat64HoleMode> {
-    CheckFloat64HoleNaNOperatortor()
+    CheckFloat64HoleNaNOperator()
         : Operator1<CheckFloat64HoleMode>(
               IrOpcode::kCheckFloat64Hole,
-              Operator::kFoldable | Operator::kNoDeopt, "CheckFloat64Hole", 1,
+              Operator::kFoldable | Operator::kNoThrow, "CheckFloat64Hole", 1,
               1, 1, 1, 1, 0, kMode) {}
   };
-  CheckFloat64HoleNaNOperatortor<CheckFloat64HoleMode::kAllowReturnHole>
+  CheckFloat64HoleNaNOperator<CheckFloat64HoleMode::kAllowReturnHole>
       kCheckFloat64HoleAllowReturnHoleOperator;
-  CheckFloat64HoleNaNOperatortor<CheckFloat64HoleMode::kNeverReturnHole>
+  CheckFloat64HoleNaNOperator<CheckFloat64HoleMode::kNeverReturnHole>
       kCheckFloat64HoleNeverReturnHoleOperator;
 
   template <CheckTaggedHoleMode kMode>
   struct CheckTaggedHoleOperator final : public Operator1<CheckTaggedHoleMode> {
     CheckTaggedHoleOperator()
         : Operator1<CheckTaggedHoleMode>(
               IrOpcode::kCheckTaggedHole,
-              Operator::kFoldable | Operator::kNoDeopt, "CheckTaggedHole", 1, 1,
+              Operator::kFoldable | Operator::kNoThrow, "CheckTaggedHole", 1, 1,
               1, 1, 1, 0, kMode) {}
   };
   CheckTaggedHoleOperator<CheckTaggedHoleMode::kConvertHoleToUndefined>
       kCheckTaggedHoleConvertHoleToUndefinedOperator;
   CheckTaggedHoleOperator<CheckTaggedHoleMode::kNeverReturnHole>
       kCheckTaggedHoleNeverReturnHoleOperator;
 
-  struct CheckIfOperator final : public Operator {
-    CheckIfOperator()
-        : Operator(IrOpcode::kCheckIf, Operator::kFoldable | Operator::kNoDeopt,
-                   "CheckIf", 1, 1, 1, 0, 1, 0) {}
-  };
-  CheckIfOperator kCheckIf;
-
   template <PretenureFlag kPretenure>
   struct AllocateOperator final : public Operator1<PretenureFlag> {
     AllocateOperator()
         : Operator1<PretenureFlag>(
               IrOpcode::kAllocate,
               Operator::kNoDeopt | Operator::kNoThrow | Operator::kNoWrite,
               "Allocate", 1, 1, 1, 1, 1, 0, kPretenure) {}
   };
   AllocateOperator<NOT_TENURED> kAllocateNotTenuredOperator;
   AllocateOperator<TENURED> kAllocateTenuredOperator;
@@ skipping 27 matching lines @@
 
 
 SimplifiedOperatorBuilder::SimplifiedOperatorBuilder(Zone* zone)
     : cache_(kCache.Get()), zone_(zone) {}
 
 #define GET_FROM_CACHE(Name, properties, input_count) \
   const Operator* SimplifiedOperatorBuilder::Name() { return &cache_.k##Name; }
 PURE_OP_LIST(GET_FROM_CACHE)
 #undef GET_FROM_CACHE
 
-#define GET_FROM_CACHE(Name) \
+#define GET_FROM_CACHE(Name, value_input_count) \
   const Operator* SimplifiedOperatorBuilder::Name() { return &cache_.k##Name; }
 CHECKED_OP_LIST(GET_FROM_CACHE)
 #undef GET_FROM_CACHE
 
 const Operator* SimplifiedOperatorBuilder::CheckFloat64Hole(
     CheckFloat64HoleMode mode) {
   switch (mode) {
     case CheckFloat64HoleMode::kAllowReturnHole:
       return &cache_.kCheckFloat64HoleAllowReturnHoleOperator;
     case CheckFloat64HoleMode::kNeverReturnHole:
       return &cache_.kCheckFloat64HoleNeverReturnHoleOperator;
   }
   UNREACHABLE();
   return nullptr;
 }
 
 const Operator* SimplifiedOperatorBuilder::CheckTaggedHole(
     CheckTaggedHoleMode mode) {
   switch (mode) {
     case CheckTaggedHoleMode::kConvertHoleToUndefined:
       return &cache_.kCheckTaggedHoleConvertHoleToUndefinedOperator;
     case CheckTaggedHoleMode::kNeverReturnHole:
       return &cache_.kCheckTaggedHoleNeverReturnHoleOperator;
   }
   UNREACHABLE();
   return nullptr;
 }
 
-const Operator* SimplifiedOperatorBuilder::CheckIf() {
-  return &cache_.kCheckIf;
-}
-
 const Operator* SimplifiedOperatorBuilder::ReferenceEqual(Type* type) {
   return new (zone()) Operator(IrOpcode::kReferenceEqual,
                                Operator::kCommutative | Operator::kPure,
                                "ReferenceEqual", 2, 0, 0, 1, 0, 0);
 }
 
 const Operator* SimplifiedOperatorBuilder::CheckBounds() {
   // TODO(bmeurer): Cache this operator. Make it pure!
   return new (zone())
       Operator(IrOpcode::kCheckBounds, Operator::kFoldable | Operator::kNoThrow,
@@ skipping 102 matching lines @@
                         Operator::kNoDeopt | Operator::kNoThrow | properties,  \
                         #Name, value_input_count, 1, control_input_count,      \
                         output_count, 1, 0, access);                           \
   }
 ACCESS_OP_LIST(ACCESS)
 #undef ACCESS
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8