Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2082983003: MD Settings: App drawer, remove TODO about waterfall effect. (Closed)

Created:
4 years, 6 months ago by dpapad
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: App drawer, remove TODO about waterfall effect. BUG=621718 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/73fc005b160471c4ce9bdf14c4b97778e7166d09 Cr-Commit-Position: refs/heads/master@{#401145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dpapad
4 years, 6 months ago (2016-06-21 21:43:52 UTC) #3
dschuyler
lgtm
4 years, 6 months ago (2016-06-21 22:57:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082983003/1
4 years, 6 months ago (2016-06-21 23:00:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 00:26:02 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 00:27:45 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/73fc005b160471c4ce9bdf14c4b97778e7166d09
Cr-Commit-Position: refs/heads/master@{#401145}

Powered by Google App Engine
This is Rietveld 408576698