Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2774)

Unified Diff: chrome/browser/engagement/site_engagement_score.cc

Issue 2082953002: Prevent site engagement scores from decaying when Chrome isn't in use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_score.cc
diff --git a/chrome/browser/engagement/site_engagement_score.cc b/chrome/browser/engagement/site_engagement_score.cc
index e55522045d8d960b462824f6449629d9f2623d7e..d2054a97b40e92c2c5fc6cb6add1a734af3c81d7 100644
--- a/chrome/browser/engagement/site_engagement_score.cc
+++ b/chrome/browser/engagement/site_engagement_score.cc
@@ -42,6 +42,8 @@ const char* kVariationNames[] = {
"first_daily_engagement_points",
"medium_engagement_boundary",
"high_engagement_boundary",
+ "max_decays_per_score",
+ "last_engagement_grace_period_in_hours",
};
bool DoublesConsideredDifferent(double value1, double value2, double delta) {
@@ -83,6 +85,8 @@ double SiteEngagementScore::param_values[] = {
8, // BOOTSTRAP_POINTS
5, // MEDIUM_ENGAGEMENT_BOUNDARY
50, // HIGH_ENGAGEMENT_BOUNDARY
+ 1, // MAX_DECAYS_PER_SCORE
+ 72, // LAST_ENGAGEMENT_GRACE_PERIOD_IN_HOURS
};
const char* SiteEngagementScore::kRawScoreKey = "rawScore";
@@ -139,6 +143,14 @@ double SiteEngagementScore::GetHighEngagementBoundary() {
return param_values[HIGH_ENGAGEMENT_BOUNDARY];
}
+double SiteEngagementScore::GetMaxDecaysPerScore() {
+ return param_values[MAX_DECAYS_PER_SCORE];
+}
+
+double SiteEngagementScore::GetLastEngagementGracePeriodInHours() {
+ return param_values[LAST_ENGAGEMENT_GRACE_PERIOD_IN_HOURS];
+}
+
// static
void SiteEngagementScore::UpdateFromVariations(const char* param_name) {
double param_vals[MAX_VARIATION];
@@ -337,6 +349,8 @@ void SiteEngagementScore::SetParamValuesForTesting() {
param_values[BOOTSTRAP_POINTS] = 8;
param_values[MEDIUM_ENGAGEMENT_BOUNDARY] = 5;
param_values[HIGH_ENGAGEMENT_BOUNDARY] = 50;
+ param_values[MAX_DECAYS_PER_SCORE] = 1;
+ param_values[LAST_ENGAGEMENT_GRACE_PERIOD_IN_HOURS] = 72;
// This is set to zero to avoid interference with tests and is set when
// testing this functionality.
« no previous file with comments | « chrome/browser/engagement/site_engagement_score.h ('k') | chrome/browser/engagement/site_engagement_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698