Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2082933002: Fix crash in app list view delegate. (Closed)

Created:
4 years, 6 months ago by calamity
Modified:
4 years, 6 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in app list view delegate. This CL fixes an issue where an observer was not removed from the app list view delegate when the profile was set to nullptr. This caused a crash if the TemplateURLService notified the app list view delegate. BUG=620220 Committed: https://crrev.com/ca75961e35cc647ae8375768b67d61276e14465a Cr-Commit-Position: refs/heads/master@{#401541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
calamity
4 years, 6 months ago (2016-06-21 08:10:34 UTC) #2
Matt Giuca
lgtm
4 years, 6 months ago (2016-06-22 02:02:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082933002/1
4 years, 6 months ago (2016-06-23 04:10:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 04:49:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 04:51:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca75961e35cc647ae8375768b67d61276e14465a
Cr-Commit-Position: refs/heads/master@{#401541}

Powered by Google App Engine
This is Rietveld 408576698