Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2082863003: Refactor the functions related to collecting code statistics to a new class. (Closed)

Created:
4 years, 6 months ago by mythria
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor the functions related to collecting code statistics to a new class. The functions related to code statistics are a part of spaces currently. This is not very intutive and hence refactored these functions to a new CodeStatistics class. BUG= LOG=N Committed: https://crrev.com/b83dbf65028431030b56e1095f94d766e1d0febc Cr-Commit-Position: refs/heads/master@{#37440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -202 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/heap/code-stats.h View 1 chunk +42 lines, -0 lines 0 comments Download
A src/heap/code-stats.cc View 1 chunk +220 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 4 chunks +0 lines, -192 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082863003/1
4 years, 6 months ago (2016-06-21 10:22:33 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 10:49:40 UTC) #4
mythria
Hi Hannes, This is the follow up cl for the code statistics (https://codereview.chromium.org/1997363002/). I moved ...
4 years, 6 months ago (2016-06-21 10:54:41 UTC) #6
Hannes Payer (out of office)
lgtm
4 years, 5 months ago (2016-06-28 17:44:27 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2082863003/1
4 years, 5 months ago (2016-06-30 09:40:19 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 10:16:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2082863003/1
4 years, 5 months ago (2016-06-30 13:18:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 13:21:17 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 13:22:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b83dbf65028431030b56e1095f94d766e1d0febc
Cr-Commit-Position: refs/heads/master@{#37440}

Powered by Google App Engine
This is Rietveld 408576698