chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js - Issue 2082863002: [MD Settings] Allow saving addresses in material design settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

Issue 2082863002: [MD Settings] Allow saving addresses in material design settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@address-edit-dialog.gitbr

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js » ('j') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

index 94556a785cec233c14261e9530d7ebc675205eef..97e2d9cb4164d14c4d3dab5d3114900191c9f166 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

@@ -209,7 +209,7 @@ Polymer({

onUpdatePhoneNumber_: function(phoneNumber) {

if (this.address_)

- this.address_.phoneNumbers = [phoneNumber];

+ this.address_.phoneNumbers = phoneNumber ? [phoneNumber] : [];

/**

@@ -219,7 +219,7 @@ Polymer({

onUpdateEmail_: function(email) {

if (this.address_)

- this.address_.emailAddresses = [email];

+ this.address_.emailAddresses = email ? [email] : [];

});

})();