Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 208283005: Make InterpolationRecord GarbageCollectedFinalized (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Make InterpolationRecord GarbageCollectedFinalized Since InterpolationRecord has a RefPtr, it should be GarbageCollectedFinalized. BUG=340522 TBR=ager Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169935

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/animation/InterpolationEffect.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
haraken
Committed patchset #2 manually as r169935 (presubmit successful).
6 years, 9 months ago (2014-03-25 12:15:19 UTC) #1
Mads Ager (chromium)
LGTM, thanks
6 years, 9 months ago (2014-03-25 12:16:20 UTC) #2
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-25 12:35:48 UTC) #3
zerny-chromium
This should have been caught by the plugin but does not appear to be. Investigating. ...
6 years, 9 months ago (2014-03-25 12:58:54 UTC) #4
haraken
On 2014/03/25 12:58:54, zerny-chromium wrote: > This should have been caught by the plugin but ...
6 years, 9 months ago (2014-03-25 13:23:14 UTC) #5
zerny-chromium
6 years, 9 months ago (2014-03-25 13:26:42 UTC) #6
It might be the error I've fixed in:
https://codereview.chromium.org/204543005/

I'm not sure the plugin actually caches the error in this CL. Maybe due to
InterpolationRecord being an inner class. I'll take a look at this.


On Tue, Mar 25, 2014 at 2:23 PM, <haraken@chromium.org> wrote:

> On 2014/03/25 12:58:54, zerny-chromium wrote:
>
>> This should have been caught by the plugin but does not appear to be.
>> Investigating.
>>
>
> Sorry, I didn't run the plugin :) (Now I have an error when running the
> plugin
> probably due to my local environment setting. Investigating.)
>
>
> https://codereview.chromium.org/208283005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698