Issue 208283002: Add special check for topmost optimized code in deoptimizer verification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208283002: Add special check for topmost optimized code in deoptimizer verification. (Closed)

Created:
6 years, 9 months ago by ulan

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add special check for topmost optimized code in deoptimizer verification. BUG=354843 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20167

Patch Set 2 : fix name #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -24 lines)			Patch
	M	src/deoptimizer.cc	View	1	2 chunks	+38 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nit. Thanks for fixing this! https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc#newcode363 src/deoptimizer.cc:363: bool safe_to_deopt_topmost_optmized_code ...

6 years, 9 months ago (2014-03-21 14:50:26 UTC) #2

ulan

Thanks, landing. https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc#newcode363 src/deoptimizer.cc:363: bool safe_to_deopt_topmost_optmized_code = false; On 2014/03/21 14:50:27, ...

6 years, 9 months ago (2014-03-21 14:54:22 UTC) #3

ulan

6 years, 9 months ago (2014-03-21 15:03:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20167 (presubmit successful).

Expand Messages | Collapse Messages

Issue 208283002: Add special check for topmost optimized code in deoptimizer verification. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix name #

Messages