Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2082823002: Flip official Win builders to GN (on trunk). (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brettw, brucedawson, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip official Win builders to GN (on trunk). This also flips the continuous official builders, but because those are pulling MB configs from versioned code, this'll only actually affect the trunk builder for now. When we branch, the branch builders will also start to pick up these changes. R=brettw@chromium.org, brucedawson@chromium.org, scottmg@chromium.org BUG=605318 Committed: https://crrev.com/44265dd04f839147986041fa9c32e9b3c758aebf Cr-Commit-Position: refs/heads/master@{#400827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082823002/1
4 years, 6 months ago (2016-06-20 21:51:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 22:58:27 UTC) #4
brucedawson
lgtm
4 years, 6 months ago (2016-06-20 23:07:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082823002/1
4 years, 6 months ago (2016-06-20 23:12:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 23:17:51 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44265dd04f839147986041fa9c32e9b3c758aebf Cr-Commit-Position: refs/heads/master@{#400827}
4 years, 6 months ago (2016-06-20 23:20:34 UTC) #10
Dirk Pranke
4 years, 6 months ago (2016-06-21 03:54:35 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2077353003/ by dpranke@chromium.org.

The reason for reverting is: Didn't work - see crbug.com/621776..

Powered by Google App Engine
This is Rietveld 408576698