Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2082793007:
Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. (Closed)
|
Created:
4 years, 6 months ago by Robert Sesek Modified:
4 years, 6 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl.
This causes a run-time dependency on libcommand_buffer_gles2.dylib that
does not exist in GYP.
BUG=621932
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=piman@chromium.org
Committed: https://crrev.com/66c5718b28d1dff3d05628218fe5207477b9f923
Cr-Commit-Position: refs/heads/master@{#401284}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 ========== to ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082793007/1
jmadill@chromium.org changed reviewers: + jmadill@chromium.org
It's odd, I think this runs with command buffer. We should probably test this locally, but LGTM if you want to land/watch/revert
On 2016/06/21 23:18:56, Jamie Madill wrote: > It's odd, I think this runs with command buffer. We should probably test this > locally, but LGTM if you want to land/watch/revert Sent it to the CQ dry run for sanity checks. But if that passes I think it's OK to land. GYP definitely doesn't have this dylib as a dependency on the executable.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082793007/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
jmadill@chromium.org changed reviewers: + piman@chromium.org
you'll need to get an LGTM from an owner (eg piman) or TBR
Description was changed from ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=piman@chromium.org ==========
On 2016/06/22 14:57:19, Jamie Madill wrote: > you'll need to get an LGTM from an owner (eg piman) or TBR Will TBR since this has been red awhile. Fine to revert if this is the wrong thing (or if it doesn't work).
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082793007/1
Message was sent while issue was closed.
Description was changed from ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=piman@chromium.org ========== to ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=piman@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=piman@chromium.org ========== to ========== Remove dependency //gpu:command_buffer_gles2 on //gpu/gles2_conform_support/egl. This causes a run-time dependency on libcommand_buffer_gles2.dylib that does not exist in GYP. BUG=621932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=piman@chromium.org Committed: https://crrev.com/66c5718b28d1dff3d05628218fe5207477b9f923 Cr-Commit-Position: refs/heads/master@{#401284} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/66c5718b28d1dff3d05628218fe5207477b9f923 Cr-Commit-Position: refs/heads/master@{#401284} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
