Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 2082793003: MD Settings: First iteration of searching within settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cr_search_migration0
Patch Set: Nits. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/advanced_page/advanced_page.js
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js
index 725e2f2ca262b76d0475eaecb964f57be2152111..b0b80d7aaf68f733e544d78843de86fa4c0864ce 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js
@@ -37,4 +37,9 @@ Polymer({
* is fixed.
*/
sectionSelector: 'settings-section',
+
+ /** override */
+ ready: function() {
+ this.fire('advanced-page-ready');
michaelpg 2016/06/27 23:00:04 i'm not sure this event is necessary. ready is cal
dpapad 2016/06/27 23:37:26 I tried using observeNodes() (after your suggestio
michaelpg 2016/06/29 01:18:57 you could try adding a listener for the dom-if's d
dpapad 2016/06/29 18:20:12 Removed this event.
+ },
});

Powered by Google App Engine
This is Rietveld 408576698