Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 2082793003: MD Settings: First iteration of searching within settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cr_search_migration0
Patch Set: Nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-advanced-page' is the settings page containing the advanced 7 * 'settings-advanced-page' is the settings page containing the advanced
8 * settings. 8 * settings.
9 */ 9 */
10 Polymer({ 10 Polymer({
(...skipping 19 matching lines...) Expand all
30 notify: true, 30 notify: true,
31 }, 31 },
32 }, 32 },
33 33
34 /** 34 /**
35 * @type {string} Selector to get the sections. 35 * @type {string} Selector to get the sections.
36 * TODO(michaelpg): replace duplicate docs with @override once b/24294625 36 * TODO(michaelpg): replace duplicate docs with @override once b/24294625
37 * is fixed. 37 * is fixed.
38 */ 38 */
39 sectionSelector: 'settings-section', 39 sectionSelector: 'settings-section',
40
41 /** override */
42 ready: function() {
43 this.fire('advanced-page-ready');
michaelpg 2016/06/27 23:00:04 i'm not sure this event is necessary. ready is cal
dpapad 2016/06/27 23:37:26 I tried using observeNodes() (after your suggestio
michaelpg 2016/06/29 01:18:57 you could try adding a listener for the dom-if's d
dpapad 2016/06/29 18:20:12 Removed this event.
44 },
40 }); 45 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698