Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2082783002: Add all content_junit tests to GN config (Closed)

Created:
4 years, 6 months ago by kraush
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add all content_junit tests to GN config This change adds all the content_junit tests to their GN config and adjusts ThreadedInputConnectionTest to work with the fact that it is now based on BaseInputConnection BUG=621630 Committed: https://crrev.com/472201e210c18ff0bef1e4e17accff896966ff1b Cr-Commit-Position: refs/heads/master@{#401181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M content/public/android/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kraush
Hi David, Can you take a look at this change to enable some additional tests ...
4 years, 6 months ago (2016-06-20 19:57:54 UTC) #2
David Trainor- moved to gerrit
lgtm tanks!
4 years, 6 months ago (2016-06-21 23:20:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082783002/1
4 years, 6 months ago (2016-06-21 23:47:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 02:51:22 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 02:55:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/472201e210c18ff0bef1e4e17accff896966ff1b
Cr-Commit-Position: refs/heads/master@{#401181}

Powered by Google App Engine
This is Rietveld 408576698