Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2082773002: Remove calls to MessageLoop::current() in net. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 5 months ago
Reviewers:
agl, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in net. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=agl@chromium.org Committed: https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d Cr-Commit-Position: refs/heads/master@{#402805}

Patch Set 1 #

Total comments: 2

Patch Set 2 : forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M net/dns/serial_worker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mock_proxy_resolver.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/proxy/mock_proxy_resolver.cc View 2 chunks +1 line, -7 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 18:54:48 UTC) #1
fdoray
+gavinp@chromium.org: Can you review this CL? Thanks.
4 years, 5 months ago (2016-06-28 21:08:49 UTC) #3
agl
LGTM. sorry, missed this email. https://codereview.chromium.org/2082773002/diff/1/net/quic/quic_connection_logger.h File net/quic/quic_connection_logger.h (right): https://codereview.chromium.org/2082773002/diff/1/net/quic/quic_connection_logger.h#newcode14 net/quic/quic_connection_logger.h:14: #include "base/metrics/histogram_base.h" Could HistogramBase ...
4 years, 5 months ago (2016-06-28 22:59:44 UTC) #4
fdoray
https://codereview.chromium.org/2082773002/diff/1/net/quic/quic_connection_logger.h File net/quic/quic_connection_logger.h (right): https://codereview.chromium.org/2082773002/diff/1/net/quic/quic_connection_logger.h#newcode14 net/quic/quic_connection_logger.h:14: #include "base/metrics/histogram_base.h" On 2016/06/28 22:59:44, agl wrote: > Could ...
4 years, 5 months ago (2016-06-29 13:32:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2082773002/20001
4 years, 5 months ago (2016-06-29 13:33:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 14:44:46 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 14:44:48 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 14:46:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/392099634d1ca439a1365569f558a5661af17a0d
Cr-Commit-Position: refs/heads/master@{#402805}

Powered by Google App Engine
This is Rietveld 408576698