Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2082733002: Fix for PDF find-in-page bug. (Closed)

Created:
4 years, 6 months ago by paulmeyer
Modified:
4 years, 6 months ago
Reviewers:
ncarter (slow), dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for PDF find-in-page bug. The problem was that the internal find identifier in PepperPluginInstanceImpl was not being updated when selectFindResult() was called, which resulted in the incorrect find request ID being reported in the find reply. BUG=621304 Committed: https://crrev.com/e39a61d57a81807380a1d6817840d7452760e5f9 Cr-Commit-Position: refs/heads/master@{#401374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebPlugin.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
paulmeyer
+nick@ for content review.
4 years, 6 months ago (2016-06-20 17:31:39 UTC) #2
paulmeyer
4 years, 6 months ago (2016-06-22 14:07:53 UTC) #4
ncarter (slow)
lgtm
4 years, 6 months ago (2016-06-22 16:19:42 UTC) #6
paulmeyer
+dcheng@ for review of WebPlugin.h
4 years, 6 months ago (2016-06-22 16:24:30 UTC) #9
dcheng
lgtm
4 years, 6 months ago (2016-06-22 16:39:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082733002/1
4 years, 6 months ago (2016-06-22 17:30:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 18:53:34 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:58:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e39a61d57a81807380a1d6817840d7452760e5f9
Cr-Commit-Position: refs/heads/master@{#401374}

Powered by Google App Engine
This is Rietveld 408576698