Fix JSON tests, re-enable in all cases

Fix JSON tests, re-enable in all cases

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34440

[kevmoo, 2014-03-21 16:38:16]

We need to merge these with tests in tests/lib/convert

But having this coverage work everywhere is a good first step

Checked with vm, dartium, dart2js, etc

[Lasse Reichstein Nielsen, 2014-03-26 11:41:31]

https://codereview.chromium.org/208273003/diff/1/tests/json/json_test.dart
File tests/json/json_test.dart (right):

https://codereview.chromium.org/208273003/diff/1/tests/json/json_test.dart#ne...
tests/json/json_test.dart:12: 
Just move the file to test/lib/convert/json2_test.dart and remove the tests/json
directory entirely.

That should be a safe move (test expectations included, of course).

Maybe add a 
  // Moved from "tests/json/json_test.dart"
comment

We can then look at whether it's redundant at some later time (or, more likely,
not).

https://codereview.chromium.org/208273003/diff/1/tests/json/pubspec.yaml
File tests/json/pubspec.yaml (right):

https://codereview.chromium.org/208273003/diff/1/tests/json/pubspec.yaml#newc...
tests/json/pubspec.yaml:4: unittest: any
What does this file do?
I think it's safe to remove.

[kevmoo, 2014-03-26 16:34:34]

PTAL

https://codereview.chromium.org/208273003/diff/1/tests/json/json_test.dart
File tests/json/json_test.dart (right):

https://codereview.chromium.org/208273003/diff/1/tests/json/json_test.dart#ne...
tests/json/json_test.dart:12: 
On 2014/03/26 11:41:31, Lasse Reichstein Nielsen wrote:
> Just move the file to test/lib/convert/json2_test.dart and remove the
tests/json
> directory entirely.
> 
> That should be a safe move (test expectations included, of course).
> 
> Maybe add a 
>   // Moved from "tests/json/json_test.dart"
> comment
> 
> We can then look at whether it's redundant at some later time (or, more
likely,
> not).

Done.

[Lasse Reichstein Nielsen, 2014-03-26 17:09:02]

lgtm

[kevmoo, 2014-03-26 17:43:27]

Committed patchset #2 manually as r34440 (presubmit successful).