Remove usage of {,un}setPendingActivity from SpeechRecognition

Source/modules/speech/SpeechRecognition.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 34 matching lines @@
 }
 
 void SpeechRecognition::start(ExceptionState& exceptionState)
 {
     ASSERT(m_controller);
     if (m_started) {
         exceptionState.throwDOMException(InvalidStateError, "recognition has already started.");
         return;
     }
 
-    setPendingActivity(this);
     m_finalResults.clear();
     m_controller->start(this, m_grammars.get(), m_lang, m_continuous, m_interimResults, m_maxAlternatives);
     m_started = true;
 }
 
 void SpeechRecognition::stopFunction()
 {
     ASSERT(m_controller);
     if (m_started && !m_stopping) {
         m_stopping = true;
@@ skipping 55 matching lines @@
 }
 
 void SpeechRecognition::didReceiveNoMatch(PassRefPtrWillBeRawPtr<SpeechRecognitionResult> result)
 {
     dispatchEvent(SpeechRecognitionEvent::createNoMatch(result));
 }
 
 void SpeechRecognition::didReceiveError(PassRefPtr<SpeechRecognitionError> error)
 {
     dispatchEvent(error);
     m_started = false;

[haraken, 2014/03/21 14:34:15]

Before this CL, we didn't unset pending activity when didReceiveError is called.
However, after this CL, we unset pending activity when didReceiveError is
called.

Is this change OK? Can you add a test that covers this behavior?

 }
 
 void SpeechRecognition::didStart()
 {
     dispatchEvent(Event::create(EventTypeNames::start));
 }
 
 void SpeechRecognition::didEnd()
 {
     m_started = false;
     m_stopping = false;
     if (!m_stoppedByActiveDOMObject)
         dispatchEvent(Event::create(EventTypeNames::end));
-    unsetPendingActivity(this);
 }
 
 const AtomicString& SpeechRecognition::interfaceName() const
 {
     return EventTargetNames::SpeechRecognition;
 }
 
 ExecutionContext* SpeechRecognition::executionContext() const
 {
     return ActiveDOMObject::executionContext();
 }
 
 void SpeechRecognition::stop()
 {
     m_stoppedByActiveDOMObject = true;
     if (hasPendingActivity())
         abort();
 }
 
+bool SpeechRecognition::hasPendingActivity() const
+{
+    return m_started;
+}
+
 SpeechRecognition::SpeechRecognition(ExecutionContext* context)
     : ActiveDOMObject(context)
     , m_grammars(SpeechGrammarList::create()) // FIXME: The spec is not clear on the default value for the grammars attribute.
     , m_continuous(false)
     , m_interimResults(false)
     , m_maxAlternatives(1)
     , m_controller(0)
     , m_stoppedByActiveDOMObject(false)
     , m_started(false)
     , m_stopping(false)
@@ skipping 14 matching lines @@
 {
 }
 
 void SpeechRecognition::trace(Visitor* visitor)
 {
     visitor->trace(m_grammars);
     visitor->trace(m_finalResults);
 }
 
 } // namespace WebCore