Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2082683003: Flip Google Chrome Win builder to GN (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Google Chrome Win builder to GN. And add the missing //:chrome_official_builder_no_unittests target that caused the prior flip to be reverted :). R=brettw@chromium.org BUG=605318, 621575 Committed: https://crrev.com/1d5b7069c8376c83fb8b3d35b0df49979592bb2a Cr-Commit-Position: refs/heads/master@{#400780}

Patch Set 1 #

Patch Set 2 : fix typo #

Patch Set 3 : make target win-only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M BUILD.gn View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-20 17:26:06 UTC) #4
brettw
lgtm
4 years, 6 months ago (2016-06-20 17:39:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082683003/20001
4 years, 6 months ago (2016-06-20 17:56:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/23596) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-20 18:03:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082683003/40001
4 years, 6 months ago (2016-06-20 19:58:55 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-20 21:09:34 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 21:13:16 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1d5b7069c8376c83fb8b3d35b0df49979592bb2a
Cr-Commit-Position: refs/heads/master@{#400780}

Powered by Google App Engine
This is Rietveld 408576698