Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2082663003: Site Settings Desktop: Convert cookie controls to distributed node. (Closed)

Created:
4 years, 6 months ago by Finnur
Modified:
4 years, 6 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Convert cookie controls to distributed node. BUG=614277, 543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d14410d0f688cd2fa4b71bd5e12ee2d44fa78a7e Cr-Commit-Position: refs/heads/master@{#400701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_category.html View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_category.js View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Finnur
4 years, 6 months ago (2016-06-20 16:21:59 UTC) #3
michaelpg
lgtm On Mon, Jun 20, 2016, 9:22 AM <finnur@chromium.org> wrote: > Reviewers: michaelpg > CL: ...
4 years, 6 months ago (2016-06-20 16:39:05 UTC) #4
michaelpg
lgtm
4 years, 6 months ago (2016-06-20 16:46:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082663003/1
4 years, 6 months ago (2016-06-20 16:47:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 17:03:47 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 17:05:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d14410d0f688cd2fa4b71bd5e12ee2d44fa78a7e
Cr-Commit-Position: refs/heads/master@{#400701}

Powered by Google App Engine
This is Rietveld 408576698