Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2082653002: Use ThreadTaskRunnerHandle::Get() in dbus. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ThreadTaskRunnerHandle::Get() in dbus. Replace MessageLoop::current()->task_runner() with ThreadTaskRunnerHandle::Get() in dbus. Why? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. BUG=616447 Committed: https://crrev.com/af82da320b8ef3521fd6fbf0e999e66097e2ed24 Cr-Commit-Position: refs/heads/master@{#400969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M dbus/bus.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-20 15:25:09 UTC) #2
hashimoto
lgtm
4 years, 6 months ago (2016-06-21 03:05:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082653002/1
4 years, 6 months ago (2016-06-21 12:40:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 12:43:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 12:47:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af82da320b8ef3521fd6fbf0e999e66097e2ed24
Cr-Commit-Position: refs/heads/master@{#400969}

Powered by Google App Engine
This is Rietveld 408576698