Issue 208263019: Small changes around GCMNetworkChannel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208263019: Small changes around GCMNetworkChannel (Closed)

Created:
6 years, 9 months ago by pavely

Modified:
6 years, 9 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, Alexei Svitkine (slow)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Small changes around GCMNetworkChannel - Add command line flag to enable GCM network channel even if experiment is not enabled - Fix hash reporting in about:invalidations - Fix condition to handle successful http status correctly - move UMA_HISTOGRAM macro into helper function BUG=325020 R=rlarocque Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259307

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -45 lines)			Patch
M	chrome/browser/invalidation/ticl_invalidation_service.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sync/notifier/gcm_network_channel.cc	View	8 chunks	+40 lines, -41 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/208263019/1

6 years, 9 months ago (2014-03-25 17:26:08 UTC) #4

Message was sent while issue was closed.

Change committed as 259307

Expand Messages | Collapse Messages