Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: media/base/demuxer_stream.h

Issue 208263018: Add SupportsConfigChanges() to DemuxerStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@audioconverterchunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/base/demuxer_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_DEMUXER_STREAM_H_ 5 #ifndef MEDIA_BASE_DEMUXER_STREAM_H_
6 #define MEDIA_BASE_DEMUXER_STREAM_H_ 6 #define MEDIA_BASE_DEMUXER_STREAM_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "media/base/media_export.h" 10 #include "media/base/media_export.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 // Returns the video decoder configuration. It is an error to call this method 62 // Returns the video decoder configuration. It is an error to call this method
63 // if type() != VIDEO. 63 // if type() != VIDEO.
64 virtual VideoDecoderConfig video_decoder_config() = 0; 64 virtual VideoDecoderConfig video_decoder_config() = 0;
65 65
66 // Returns the type of stream. 66 // Returns the type of stream.
67 virtual Type type() = 0; 67 virtual Type type() = 0;
68 68
69 virtual void EnableBitstreamConverter() = 0; 69 virtual void EnableBitstreamConverter() = 0;
70 70
71 // Whether or not this DemuxerStream allows midstream configuration changes.
scherkus (not reviewing) 2014/03/25 21:14:53 I know EnableBitsreamConverter() is sorely lacking
rileya (GONE FROM CHROMIUM) 2014/03/25 21:45:06 Added more detail.
72 virtual bool SupportsConfigChanges();
DaleCurtis 2014/03/24 19:01:00 Unfortunately, this should be = 0; and each implem
rileya (GONE FROM CHROMIUM) 2014/03/25 21:45:06 Done.
73
71 protected: 74 protected:
72 // Only allow concrete implementations to get deleted. 75 // Only allow concrete implementations to get deleted.
73 virtual ~DemuxerStream(); 76 virtual ~DemuxerStream();
74 }; 77 };
75 78
76 } // namespace media 79 } // namespace media
77 80
78 #endif // MEDIA_BASE_DEMUXER_STREAM_H_ 81 #endif // MEDIA_BASE_DEMUXER_STREAM_H_
OLDNEW
« no previous file with comments | « no previous file | media/base/demuxer_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698