LayoutTests/fast/table/resize-table-width-using-col-colgroup-span.html - Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/resize-table-width-using-col-colgroup-span.html

Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reverting to Patch Set 1 Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/table/resize-table-using-col-height-vertical-writing-mode.html ('K') | « LayoutTests/fast/table/resize-table-using-col-height-vertical-writing-mode-expected.txt ('k') | LayoutTests/fast/table/resize-table-width-using-col-colgroup-span-expected.txt » ('j') | Source/core/rendering/RenderTableCol.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 #thecol {

	6 width: 200px;

	7 }

	8 td {

	9 height: 25px;

	10 }

	11 </style>

	12 <script type="text/javascript">

	13 function runTest() {

	14 var col = document.getElementById('thecol');

	15 col.offsetTop;

	16 col.style.width="100px";

	17 window.checkLayout("#td1", document.getElementById("test-output" ));
	mstensho (USE GERRIT) 2015/01/09 21:21:35 No need for "window.". I'd also store document.ge No need for "window.". I'd also store document.getElementById("test-output") as a variable. Similar issue in other files.
	18 window.checkLayout("#td2", document.getElementById("test-output" ));

	19 window.checkLayout("#td3", document.getElementById("test-output" ));

	20 window.checkLayout("#td4", document.getElementById("test-output" ));

	21 window.checkLayout("#td5", document.getElementById("test-output" ));

	22 window.checkLayout("#td6", document.getElementById("test-output" ));

	23 window.checkLayout("#td7", document.getElementById("test-output" ));

	24 window.checkLayout("#td8", document.getElementById("test-output" ));

	25 window.checkLayout("#td9", document.getElementById("test-output" ));

	26 }

	27 </script>

	28 <script src="../../resources/check-layout.js"></script>

	29 </head>

	30 <body onload="runTest()">

	31 Tests that the width of table cell changes on changing the colgroup widt h to new width.

	32 <table>

	33 <colgroup id="thecol" span="4" style="background-color:red"/>

	34 </col>

	35 <thead>

	36 <tr>

	37 <td id="td1" data-expected-width="100"></td>

	38 <td id="td2" data-expected-width="100"></td>

	39 <td id="td3" data-expected-width="100"></td>

	40 </tr>

	41 </thead>

	42 <tfoot>

	43 <tr>

	44 <td id="td4" data-expected-width="100"></td>

	45 <td id="td5" data-expected-width="100"></td>

	46 <td id="td6" data-expected-width="100"></td>

	47 </tr>

	48 </tfoot>

	49 <tbody>

	50 <tr>

	51 <td id="td7" data-expected-width="100"></td>

	52 <td id="td8" data-expected-width="100"></td>

	53 <td id="td9" data-expected-width="100"></td>

	54 </tr>

	55 </tbody>

	56 </table>

	57 <div id="test-output"></div>

	58 </body>

	59 </html>

OLD	NEW