LayoutTests/fast/table/resize-table-using-col-height-vertical-writing-mode.html - Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/resize-table-using-col-height-vertical-writing-mode.html

Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reverting to Patch Set 1 Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/table/resize-table-using-col-height-vertical-writing-mode-expected.txt » ('j') | LayoutTests/fast/table/resize-table-width-using-col-colgroup-span.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>
	mstensho (USE GERRIT) 2015/01/09 21:21:35 Please omit unnecessary HTML, HEAD and BODY tags h Please omit unnecessary HTML, HEAD and BODY tags here and in all the other files.
	3 <head>

	4 <style>

	5 col {
	mstensho (USE GERRIT) 2015/01/09 21:21:35 Indentation is off, here, and in all the other fil Indentation is off, here, and in all the other files at the same place.
	6 height: 200px;

	7 }

	8 td {

	9 background-color: #66f;

	10 height: 25px;

	11 }

	12 </style>

	13 <script type="text/javascript">

	14 function runTest() {
	mstensho (USE GERRIT) 2015/01/09 21:21:35 To get rid of the BODY tag, you could rewrite this To get rid of the BODY tag, you could rewrite this as "onload = function() {"
	15 var col = document.getElementById('thecol');

	16 col.offsetTop;

	17 col.style.height="100px";

	18 window.checkLayout("td", document.getElementById("test-output")) ;
	mstensho (USE GERRIT) 2015/01/09 21:21:35 No need for "window.". No need for "window.".
	19 }

	20 </script>

	21 <script src="../../resources/check-layout.js"></script>

	22 </head>

	23 <body onload="runTest()">

	24 Tests that the height of table cell changes on changing the colgroup hei ght to new height.

	25 <table style="-webkit-writing-mode: vertical-lr">

	26 <colgroup>

	27 <col id="thecol">

	28 </colgroup>

	29 <tbody>

	30 <tr>

	31 <td id="colWidth" data-expected-height="100">Hello World</td >
	mstensho (USE GERRIT) 2015/01/09 21:21:35 Unused id. Unused id.
	32 </tr>

	33 </tbody>

	34 </table>

	35 <div id="test-output"></div>

	36 </body>

	37 </html>

OLD	NEW