Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: Source/core/rendering/RenderTableCol.cpp

Issue 208263013: Col width is not honored when dynamically updated and it would not make table narrower (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/table/resize-table-width-using-multiple-col-span-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 RenderBox::trace(visitor); 50 RenderBox::trace(visitor);
51 } 51 }
52 52
53 void RenderTableCol::styleDidChange(StyleDifference diff, const RenderStyle* old Style) 53 void RenderTableCol::styleDidChange(StyleDifference diff, const RenderStyle* old Style)
54 { 54 {
55 RenderBox::styleDidChange(diff, oldStyle); 55 RenderBox::styleDidChange(diff, oldStyle);
56 56
57 // If border was changed, notify table. 57 // If border was changed, notify table.
58 if (parent()) { 58 if (parent()) {
59 RenderTable* table = this->table(); 59 RenderTable* table = this->table();
60 if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout () && oldStyle && oldStyle->border() != style()->border()) 60 if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout () && oldStyle && oldStyle->border() != style()->border()) {
61 table->invalidateCollapsedBorders(); 61 table->invalidateCollapsedBorders();
62 } else if (oldStyle && oldStyle->logicalWidth() != style()->logicalWidth ()) {
63 // FIXME : setPreferredLogicalWidthsDirty is done for all cells as o f now.
64 // Need to find a better way so that only the cells which are change d by
65 // the col width should have preferred logical widths recomputed.
66 for (RenderObject* child = table->children()->firstChild(); child; c hild = child->nextSibling()) {
67 if (!child->isTableSection())
68 continue;
69 RenderTableSection* section = toRenderTableSection(child);
70 for (RenderTableRow* row = section->firstRow(); row; row = row-> nextRow()) {
71 for (RenderTableCell* cell = row->firstCell(); cell; cell = cell->nextCell())
72 cell->setPreferredLogicalWidthsDirty();
73 }
74 }
75 }
62 } 76 }
63 } 77 }
64 78
65 void RenderTableCol::updateFromElement() 79 void RenderTableCol::updateFromElement()
66 { 80 {
67 unsigned oldSpan = m_span; 81 unsigned oldSpan = m_span;
68 Node* n = node(); 82 Node* n = node();
69 if (isHTMLTableColElement(n)) { 83 if (isHTMLTableColElement(n)) {
70 HTMLTableColElement& tc = toHTMLTableColElement(*n); 84 HTMLTableColElement& tc = toHTMLTableColElement(*n);
71 m_span = tc.span(); 85 m_span = tc.span();
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 return style()->borderStart(); 194 return style()->borderStart();
181 } 195 }
182 196
183 const BorderValue& RenderTableCol::borderAdjoiningCellAfter(const RenderTableCel l* cell) const 197 const BorderValue& RenderTableCol::borderAdjoiningCellAfter(const RenderTableCel l* cell) const
184 { 198 {
185 ASSERT_UNUSED(cell, table()->colElement(cell->col() - 1) == this); 199 ASSERT_UNUSED(cell, table()->colElement(cell->col() - 1) == this);
186 return style()->borderEnd(); 200 return style()->borderEnd();
187 } 201 }
188 202
189 } 203 }
OLDNEW
« no previous file with comments | « LayoutTests/fast/table/resize-table-width-using-multiple-col-span-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698