Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: components/dom_distiller/core/url_utils_android.cc

Issue 208263010: Fix a problem that FeedbackReportingView is stacked infinitely whenever navigating to chrome-distil… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/url_utils_android.cc
diff --git a/components/dom_distiller/core/url_utils_android.cc b/components/dom_distiller/core/url_utils_android.cc
index 2f12d344a62838348b7b964eea551a2cc9070e29..d19552d1e673dcee7bf4eb840ceab566457b3898 100644
--- a/components/dom_distiller/core/url_utils_android.cc
+++ b/components/dom_distiller/core/url_utils_android.cc
@@ -34,6 +34,18 @@ jstring GetDistillerViewUrlFromUrl(JNIEnv* env,
return base::android::ConvertUTF8ToJavaString(env, view_url.spec()).Release();
}
+jboolean IsReportableUrl(JNIEnv* env,
+ jclass clazz,
+ jstring j_scheme,
+ jstring j_url) {
+ std::string scheme(base::android::ConvertJavaStringToUTF8(env, j_scheme));
+ GURL url(base::android::ConvertJavaStringToUTF8(env, j_url));
+ if (!url.is_valid()) {
nyquist 2014/03/31 23:08:25 Could you move this last part to the normal url ut
Sungmann Cho 2014/04/01 07:51:39 Done.
+ return false;
+ }
+ return url.scheme() == scheme;
+}
+
bool RegisterUrlUtils(JNIEnv* env) { return RegisterNativesImpl(env); }
} // namespace android

Powered by Google App Engine
This is Rietveld 408576698