chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java - Issue 208263010: Fix a problem that FeedbackReportingView is stacked infinitely whenever navigating to chrome-distil…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 208263010: Fix a problem that FeedbackReportingView is stacked infinitely whenever navigating to chrome-distil… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java ('k') | chrome/browser/android/dom_distiller/feedback_reporter_android.h » ('j') | chrome/browser/android/dom_distiller/feedback_reporter_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

index 54c920ae5f92f9ba34c81096189b0bc616f70775..0df43d1f87777a5738cca80161891e195d0743d5 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

@@ -347,8 +347,8 @@ public class ChromeShellActivity extends Activity implements AppMenuPropertiesDe

MenuItem distillPageItem = menu.findItem(R.id.distill_page);

if (CommandLine.getInstance().hasSwitch(ChromeShellSwitches.ENABLE_DOM_DISTILLER)) {

String url = activeTab != null ? activeTab.getUrl() : null;

- distillPageItem.setEnabled(!TextUtils.isEmpty(url) &&

- !url.startsWith(CHROME_DISTILLER_SCHEME));

+ distillPageItem.setEnabled(!DomDistillerUrlUtils.isReportableUrl(

+ CHROME_DISTILLER_SCHEME, activeTab.getUrl()));

nyquist 2014/03/31 23:08:25 Use |url| here.

Sungmann Cho 2014/04/01 07:51:39 Done.

distillPageItem.setVisible(true);

} else {

distillPageItem.setVisible(false);