Fix a problem that FeedbackReportingView is stacked infinitely whenever navigating to chrome-distil…

chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java

Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java
index 8661274438b380d1cb467b1cb8768efc5666df7f..6c140093ed7b86ff74716d2c97101765f8e86afa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java
@@ -22,7 +22,6 @@ public final class FeedbackReporter implements FeedbackReportingView.FeedbackObs
     private final Tab mTab;
     private ContentView mContentView;
     private FeedbackReportingView mFeedbackReportingView;
-    private String mOverlayUrl;
 
     /**
      * @return whether the DOM Distiller feature is enabled.
@@ -70,6 +69,7 @@ public final class FeedbackReporter implements FeedbackReportingView.FeedbackObs
     /**
      * Start showing the overlay.
      */
+    @CalledByNative
     private void showOverlay() {
         mFeedbackReportingView = FeedbackReportingView.create(mContentView, this);
     }
@@ -79,14 +79,10 @@ public final class FeedbackReporter implements FeedbackReportingView.FeedbackObs
      */
     @CalledByNative
     private void dismissOverlay() {
-        if (mFeedbackReportingView != null) mFeedbackReportingView.dismiss(true);
-        mOverlayUrl = null;
-        mFeedbackReportingView = null;
-    }
-
-    @CalledByNative
-    private String getCurrentOverlayUrl() {
-        return mOverlayUrl;
+        if (mFeedbackReportingView != null) {
+            mFeedbackReportingView.dismiss(true);
+            mFeedbackReportingView = null;
+        }
     }
 
     /**
@@ -117,17 +113,6 @@ public final class FeedbackReporter implements FeedbackReportingView.FeedbackObs
             }
 
             @Override
-            public void onUpdateUrl(Tab tab, String url) {
-                boolean reportable = nativeIsReportableUrl(url);
-                if (reportable) {
-                    mOverlayUrl = url;
-                    showOverlay();
-                } else {
-                    dismissOverlay();
-                }
-            }
-
-            @Override
             public void onDestroyed(Tab tab) {
                 nativeDestroy(mNativePointer);
                 mContentView = null;
@@ -137,8 +122,6 @@ public final class FeedbackReporter implements FeedbackReportingView.FeedbackObs
 
     private static native boolean nativeIsEnabled();
 
-    private static native boolean nativeIsReportableUrl(String url);

[nyquist, 2014/03/27 20:16:22]

Instead of removing this, could you move it to
org.chromium.components.dom_distiller.core.DomDistillerUrlUtils and make it
publicly available there? And then use it in
org.chromium.chrome.shell.ChromeShellActivity#prepareMenu?

[Sungmann Cho, 2014/03/28 01:28:45]

Done.

-
     private static native void nativeReportQuality(boolean good);
 
     private native long nativeInit();