Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/android/dom_distiller/feedback_reporter_android.h

Issue 208263010: Fix a problem that FeedbackReportingView is stacked infinitely whenever navigating to chrome-distil… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_DOM_DISTILLER_FEEDBACK_REPORTER_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_DOM_DISTILLER_FEEDBACK_REPORTER_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_DOM_DISTILLER_FEEDBACK_REPORTER_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_DOM_DISTILLER_FEEDBACK_REPORTER_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/jni_helper.h" 10 #include "base/android/jni_helper.h"
(...skipping 18 matching lines...) Expand all
29 void Destroy(JNIEnv* env, jobject obj); 29 void Destroy(JNIEnv* env, jobject obj);
30 30
31 // Observes a new WebContents, if necessary. 31 // Observes a new WebContents, if necessary.
32 void ReplaceWebContents(JNIEnv* env, jobject obj, jobject jweb_contents); 32 void ReplaceWebContents(JNIEnv* env, jobject obj, jobject jweb_contents);
33 33
34 // WebContentsObserver implementation: 34 // WebContentsObserver implementation:
35 virtual void DidNavigateMainFrame( 35 virtual void DidNavigateMainFrame(
36 const content::LoadCommittedDetails& details, 36 const content::LoadCommittedDetails& details,
37 const content::FrameNavigateParams& params) OVERRIDE; 37 const content::FrameNavigateParams& params) OVERRIDE;
38 38
39 static jboolean IsReportableUrl(JNIEnv* env, jclass clazz);
40
41 private: 39 private:
42 // FeedbackReporterAndroid on the Java side. 40 // FeedbackReporterAndroid on the Java side.
43 JavaObjectWeakGlobalRef weak_java_feedback_reporter_; 41 JavaObjectWeakGlobalRef weak_java_feedback_reporter_;
44 42
45 DISALLOW_COPY_AND_ASSIGN(FeedbackReporterAndroid); 43 DISALLOW_COPY_AND_ASSIGN(FeedbackReporterAndroid);
46 }; 44 };
47 45
48 // Registers the FeedbackReporter's native methods through JNI. 46 // Registers the FeedbackReporter's native methods through JNI.
49 bool RegisterFeedbackReporter(JNIEnv* env); 47 bool RegisterFeedbackReporter(JNIEnv* env);
50 48
51 } // namespace android 49 } // namespace android
52 50
53 } // namespace dom_distiller 51 } // namespace dom_distiller
54 52
55 #endif // CHROME_BROWSER_ANDROID_DOM_DISTILLER_FEEDBACK_REPORTER_ANDROID_H_ 53 #endif // CHROME_BROWSER_ANDROID_DOM_DISTILLER_FEEDBACK_REPORTER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698