Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 208263008: Revert 258763 "Adds plumbing to pass WebUI mojo::Handle from bro..." (Closed)

Created:
6 years, 9 months ago by Dan Beam
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 258763 "Adds plumbing to pass WebUI mojo::Handle from bro..." Broke compile on Linux Builder (dbg): FAILED: /b/build/goma/gomacc c++ -MMD -MF obj/content/gen/mojo/common/mojo/content_common_mojo_bindings.render_process.mojom.o.d -DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_MOJO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../.. -Igen -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -msse2 -mfpmath=sse -mmmx -m32 -O0 -g -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -c gen/mojo/common/mojo/render_process.mojom.cc -o obj/content/gen/mojo/common/mojo/content_common_mojo_bindings.render_process.mojom.o gen/mojo/common/mojo/render_process.mojom.cc:10:54: fatalerror: content/common/mojo/render_process.mojom.h: No such file or directory compilation terminated. > Adds plumbing to pass WebUI mojo::Handle from browser to renderer > > See the test for details on how it'll all work out in practice. > > BUG=none > TEST=none > R=darin@chromium.org > > Review URL: https://codereview.chromium.org/206923002 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -672 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.h View 5 chunks +7 lines, -12 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 5 chunks +32 lines, -16 lines 0 comments Download
D trunk/src/content/browser/renderer_host/render_process_host_mojo_impl.h View 1 chunk +0 lines, -54 lines 0 comments Download
D trunk/src/content/browser/renderer_host/render_process_host_mojo_impl.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M trunk/src/content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M trunk/src/content/common/mojo/mojo_channel_init.h View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/content/common/mojo/mojo_channel_init.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M trunk/src/content/common/mojo/mojo_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/content/common/mojo/render_process.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/content/content.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 2 chunks +1 line, -10 lines 0 comments Download
D trunk/src/content/content_common_mojo_bindings.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
M trunk/src/content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/content_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 3 chunks +0 lines, -30 lines 0 comments Download
M trunk/src/content/public/browser/render_view_host.h View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/content/public/browser/web_ui_data_source.h View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/content/renderer/mojo/mojo_render_process_observer.h View 3 chunks +1 line, -12 lines 0 comments Download
M trunk/src/content/renderer/mojo/mojo_render_process_observer.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/content/renderer/web_ui_mojo.h View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/web_ui_mojo.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/content/renderer/web_ui_mojo_context_state.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/web_ui_mojo_context_state.cc View 2 chunks +3 lines, -4 lines 0 comments Download
D trunk/src/content/test/data/web_ui_mojo.html View 1 chunk +0 lines, -8 lines 0 comments Download
D trunk/src/content/test/data/web_ui_mojo.js View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/src/content/test/data/web_ui_test_mojo_bindings.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
M trunk/src/mojo/mojo_public.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/mojo/public/bindings/js/constants.h View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/src/mojo/public/bindings/js/constants.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
6 years, 9 months ago (2014-03-22 03:58:01 UTC) #1
Dan Beam
6 years, 9 months ago (2014-03-22 03:59:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r258769 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698