Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 208263005: Deprecate webkitRequestAnimationFrame and friends as vendor-specific (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Deprecate webkitRequestAnimationFrame and friends as vendor-specific Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/nNsZDn_utUc/dUtD3ulsFMkJ BUG=354921 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169924

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-21 17:18:15 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-24 03:35:39 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-24 06:03:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/208263005/1
6 years, 9 months ago (2014-03-24 06:03:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 06:05:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 06:05:32 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-24 07:33:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/208263005/1
6 years, 9 months ago (2014-03-24 07:33:03 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 08:06:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 08:06:06 UTC) #10
philipj_slow
Looks like the calendar picker uses this internally, better fix that first: https://codereview.chromium.org/209003012/
6 years, 9 months ago (2014-03-24 17:43:01 UTC) #11
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 08:17:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/208263005/20001
6 years, 9 months ago (2014-03-25 08:17:26 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 08:19:59 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 08:19:59 UTC) #15
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 08:30:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/208263005/20001
6 years, 9 months ago (2014-03-25 08:30:28 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 08:32:21 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 08:32:21 UTC) #19
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 08:34:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/208263005/20001
6 years, 9 months ago (2014-03-25 08:34:24 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 09:15:57 UTC) #22
Message was sent while issue was closed.
Change committed as 169924

Powered by Google App Engine
This is Rietveld 408576698