Introduce an 'ENABLE_WEBSOCKETS' define in //net.

net/BUILD.gn

Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index 020e7d170fc60753f06f48d85b43cd75bceac719..c8cc2a6c074a57b189ff2c49fd54516c318d83b8 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -68,6 +68,9 @@ config("net_config") {
   if (disable_ftp_support) {
     defines += [ "DISABLE_FTP_SUPPORT=1" ]
   }
+  if (enable_websockets) {
+    defines += [ "ENABLE_WEBSOCKETS" ]

[mmenke, 2016/06/20 15:14:09]

Hrm...We should probably go with DISABLE_WEBSOCKETS instead.  The other features
use default on, don't see why this should be different.  Admittedly, mixing that
with the enable_websockets gyp/gn define is a little confusing.  Probably worth
changing that as well at some point - feel free to do that now, in this CL, but
also feel free not to.

Doesn't look like it's used outside net, so should be a pretty simple change.

[Mike West, 2016/06/21 10:31:15]

It doesn't look that clearcut. We have
"DISABLE_FILE_SUPPORT"/"DISABLE_FTP_SUPPORT"/"disable_brotli_filter" one the one
hand, but
"ENABLE_WEBSOCKETS"/"ENABLE_BUILT_IN_DNS"/"USE_KERBEROS"/"use_v8_in_net" on the
other.
If aligning on one or the other would help clarify things for the build, great.
I think that can be done in a separate CL, however.

WDYT?


 

[mmenke, 2016/06/21 16:33:54]

SGTM.

+  }
 }
 
 config("net_internal_config") {