Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2082563002: Revert of MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all. (Closed)

Created:
4 years, 6 months ago by benwells
Modified:
4 years, 6 months ago
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all. (patchset #3 id:40001 of https://codereview.chromium.org/2076083003/ ) Reason for revert: New test is failing on DrMemory :( First failing build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%281%29/builds/3504 Sample test output: MdSettingsBrowserTest.BackForwardDoesntCrash: Did not complete. Original issue's description: > MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all. > > But... > > ONCE AND FOR ALL! > > BUG=620370 > R=groby@chromium.org > > Committed: https://crrev.com/b8e015295703f0f5689688a99c5d232b89db9325 > Cr-Commit-Position: refs/heads/master@{#400528} TBR=groby@chromium.org,michaelpg@chromium.org,dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=620370 Committed: https://crrev.com/30f8b46a1fbea34790cd000f4a9871849461f1e4 Cr-Commit-Position: refs/heads/master@{#400654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -30 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc View 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
benwells
Created Revert of MD Settings: ... and we fixed all CHECK()-based URL crashes once and ...
4 years, 6 months ago (2016-06-20 10:59:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082563002/1
4 years, 6 months ago (2016-06-20 10:59:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 11:36:11 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 11:37:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30f8b46a1fbea34790cd000f4a9871849461f1e4
Cr-Commit-Position: refs/heads/master@{#400654}

Powered by Google App Engine
This is Rietveld 408576698