third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 2082553002: Reland of Check DisplayItemCient aliveness in cached subsequences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2082553002: Reland of Check DisplayItemCient aliveness in cached subsequences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index 328f526b78a7372bf9597917619db1abcf696633..badaf8ba989625a06b757b2778e97727d286676d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -961,6 +961,12 @@

{

if (m_compositor)

m_compositor->setIsInWindow(isInWindow);

+#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS

+ // We don't invalidate layers during document detach(), so must clear the should-keep-alive

+ // DisplayItemClients which may be deleted before the layers being subsequence owners.

+ if (!isInWindow && layer())

+ layer()->endShouldKeepAliveAllClientsRecursive();

+#endif

}

IntervalArena* LayoutView::intervalArena()

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »