Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 208253003: Simplify VectorMover<true, T>::swap() (Closed)

Created:
6 years, 9 months ago by Mikhail
Modified:
6 years, 9 months ago
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium, tkent, eseidel, jochen (gone - plz use gerrit), Erik Corry
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify VectorMover<true, T>::swap() Simplify VectorMover<true, T>::swap() - use std::swap_ranges instead of creating the loop ourselves, plus the patch removes a "FIXME" comment - compiler already produces the most efficient code for POD types swap, so there is no need to introduce compex algorithms for that (checked with GCC 4.7.2). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M Source/wtf/Vector.h View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mikhail
PTAL
6 years, 9 months ago (2014-03-21 15:00:31 UTC) #1
kouhei (in TOK)
On 2014/03/21 15:00:31, mikhail.pozdnyakov wrote: > PTAL lgtm
6 years, 9 months ago (2014-03-21 15:02:37 UTC) #2
eseidel
lgtm OK.
6 years, 9 months ago (2014-03-21 16:12:52 UTC) #3
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 9 months ago (2014-03-21 16:17:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/208253003/1
6 years, 9 months ago (2014-03-21 16:18:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 16:57:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-21 16:57:51 UTC) #7
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 9 months ago (2014-03-21 17:03:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/208253003/1
6 years, 9 months ago (2014-03-21 17:03:08 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 17:32:19 UTC) #10
Message was sent while issue was closed.
Change committed as 169747

Powered by Google App Engine
This is Rietveld 408576698