Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2082513004: Remove calls to MessageLoop::current() in services. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in services. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=jam@chromium.org Committed: https://crrev.com/9b57365e023ea624c1441ab822319c183bb4bffc Cr-Commit-Position: refs/heads/master@{#401384}

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M services/shell/background/background_shell.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 18:53:50 UTC) #1
jam
lgtm
4 years, 6 months ago (2016-06-22 19:35:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082513004/20001
4 years, 6 months ago (2016-06-22 19:50:06 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 19:55:50 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 19:57:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b57365e023ea624c1441ab822319c183bb4bffc
Cr-Commit-Position: refs/heads/master@{#401384}

Powered by Google App Engine
This is Rietveld 408576698