Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2082513003: [Merge M52] Use correct origin when prompting for proxy authentication. (Closed)

Created:
4 years, 6 months ago by asanka
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Merge M52] Use correct origin when prompting for proxy authentication. Since M49, Chrome has been prompting for proxy authentication credentials using the target origin instead of the origin of the proxy server. Even if the proxy origin was displayed correctly, a mischievous network operator could still spoof the proxy server origin. To mitigate these problems, this CL: * Fixes the origin used in the proxy authentication login prompt to use the origin of the proxy server. * Indicate if the proxy server connection is insecure. * Always throw up an interstitial and clear the omnibox when showing a proxy auth prompt. * Use the correct origin when saving proxy authentication credentials. BUG=613626, 620737 Review-Url: https://codereview.chromium.org/2067933002 Cr-Commit-Position: refs/heads/master@{#400247} (cherry picked from commit 098c009df7a4ddc5c23d4d3c9dccf5eff1f24c98) Committed: https://chromium.googlesource.com/chromium/src/+/8c8b7cc66aa395a12b7a25f59d9cd4d1eb71f1a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -186 lines) Patch
M chrome/browser/ui/login/login_handler.h View 5 chunks +45 lines, -6 lines 0 comments Download
M chrome/browser/ui/login/login_handler.cc View 6 chunks +155 lines, -130 lines 0 comments Download
M chrome/browser/ui/login/login_handler_unittest.cc View 1 chunk +127 lines, -29 lines 0 comments Download
M content/shell/browser/shell_login_dialog.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/base/auth.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/auth.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_auth_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 11 chunks +22 lines, -12 lines 0 comments Download
M net/url_request/url_request_ftp_job.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
asanka
4 years, 6 months ago (2016-06-20 14:56:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c8b7cc66aa395a12b7a25f59d9cd4d1eb71f1a4.

Powered by Google App Engine
This is Rietveld 408576698