Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2082513002: Add GetCurrentURL to ClipboardRecentContentIOS (Closed)

Created:
4 years, 6 months ago by Olivier
Modified:
4 years, 6 months ago
Reviewers:
jif
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GetCurrentURL to ClipboardRecentContentIOS The today extension does not alway get notification. Check if there is a new entry before returning it. Committed: https://crrev.com/67dc844e3e82ea4a9d1d8f9eeac559d425d624f2 Cr-Commit-Position: refs/heads/master@{#400686}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M components/open_from_clipboard/clipboard_recent_content_ios.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/open_from_clipboard/clipboard_recent_content_ios.mm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Olivier
4 years, 6 months ago (2016-06-20 09:12:23 UTC) #2
jif
lgtm https://codereview.chromium.org/2082513002/diff/1/components/open_from_clipboard/clipboard_recent_content_ios.h File components/open_from_clipboard/clipboard_recent_content_ios.h (right): https://codereview.chromium.org/2082513002/diff/1/components/open_from_clipboard/clipboard_recent_content_ios.h#newcode40 components/open_from_clipboard/clipboard_recent_content_ios.h:40: // Get the current URL in the clipboard. ...
4 years, 6 months ago (2016-06-20 13:21:56 UTC) #3
Olivier
https://codereview.chromium.org/2082513002/diff/1/components/open_from_clipboard/clipboard_recent_content_ios.h File components/open_from_clipboard/clipboard_recent_content_ios.h (right): https://codereview.chromium.org/2082513002/diff/1/components/open_from_clipboard/clipboard_recent_content_ios.h#newcode40 components/open_from_clipboard/clipboard_recent_content_ios.h:40: // Get the current URL in the clipboard. If ...
4 years, 6 months ago (2016-06-20 14:51:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082513002/20001
4 years, 6 months ago (2016-06-20 14:52:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 15:40:23 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:43:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67dc844e3e82ea4a9d1d8f9eeac559d425d624f2
Cr-Commit-Position: refs/heads/master@{#400686}

Powered by Google App Engine
This is Rietveld 408576698