Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 2082503003: ASSERT -> DCHECK conversions in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.cpp
diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp
index d8e625438214f8f8f9782054af5a928346592003..ea6465f9f26a791f61c0e356e5b3c2c7f8738dec 100644
--- a/third_party/WebKit/Source/core/editing/Position.cpp
+++ b/third_party/WebKit/Source/core/editing/Position.cpp
@@ -134,7 +134,7 @@ Node* PositionTemplate<Strategy>::computeContainerNode() const
case PositionAnchorType::AfterAnchor:
return Strategy::parent(*m_anchorNode);
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0;
}
@@ -156,7 +156,7 @@ int PositionTemplate<Strategy>::computeOffsetInContainerNode() const
case PositionAnchorType::AfterAnchor:
return Strategy::index(*m_anchorNode) + 1;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0;
}
@@ -218,7 +218,7 @@ Node* PositionTemplate<Strategy>::computeNodeBeforePosition() const
case PositionAnchorType::AfterAnchor:
return m_anchorNode.get();
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0;
}
@@ -240,7 +240,7 @@ Node* PositionTemplate<Strategy>::computeNodeAfterPosition() const
case PositionAnchorType::AfterAnchor:
return Strategy::nextSibling(*m_anchorNode);
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0;
}
@@ -355,7 +355,7 @@ bool PositionTemplate<Strategy>::atFirstEditingPositionForNode() const
// of DOM tree version.
return !EditingStrategy::lastOffsetForEditing(anchorNode());
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -581,7 +581,7 @@ Position toPositionInDOMTree(const PositionInFlatTree& position)
return Position(anchorNode, PositionAnchorType::AfterChildren);
}
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return Position();
}
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/EphemeralRange.cpp ('k') | third_party/WebKit/Source/core/editing/RenderedPosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698