Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 2082483005: [Autofill] Log RAPPOR metrics around credit card upload failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: refactor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index d587208a9ce1e073610392a08581105dd427e99b..2a37e9af4eee86ef13430256b0ea3c4d13e96279 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -387,12 +387,17 @@ class AutofillManager : public AutofillDownloadManager::Observer,
// Imports the form data, submitted by the user, into |personal_data_|.
void ImportFormData(const FormStructure& submitted_form);
+ // Logs |metric_name| with RAPPOR, for the specific form |source_url|.
+ void CollectRapportSample(const GURL& source_url,
+ const char* metric_name) const;
+
// Examines |card| and the stored profiles and if a candidate set of profiles
// is found that matches the client-side validation rules, assigns the values
- // to |profiles|. If no valid set can be found, returns false.
- bool GetProfilesForCreditCardUpload(
- const CreditCard& card,
- std::vector<AutofillProfile>* profiles) const;
+ // to |profiles|. |source_url| is the source URL for the form. If no valid set
+ // can be found, returns false.
+ bool GetProfilesForCreditCardUpload(const CreditCard& card,
+ std::vector<AutofillProfile>* profiles,
+ const GURL& source_url) const;
// If |initial_interaction_timestamp_| is unset or is set to a later time than
// |interaction_timestamp|, updates the cached timestamp. The latter check is
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698