[Autofill] Log RAPPOR metrics around credit card upload failures

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 40 matching lines @@
 #include "components/autofill/core/common/autofill_data_validation.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/autofill/core/common/autofill_util.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
+#include "components/rappor/rappor_utils.h"
 #include "google_apis/gaia/identity_provider.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/geometry/rect.h"
 #include "url/gurl.h"
 
 #if defined(OS_IOS)
 #include "components/autofill/core/browser/autofill_field_trial_ios.h"
 #include "components/autofill/core/browser/keyboard_accessory_metrics_logger.h"
 #endif
@@ skipping 998 matching lines @@
     for (const AutofillField* field : submitted_form) {
       if (field->Type().GetStorableType() == CREDIT_CARD_VERIFICATION_CODE &&
           base::StringToInt(field->value, &cvc)) {
         upload_request_.cvc = field->value;
         break;
       }
     }
     if (upload_request_.cvc.empty()) {
       AutofillMetrics::LogCardUploadDecisionMetric(
           AutofillMetrics::UPLOAD_NOT_OFFERED_NO_CVC);
+      if (submitted_form.source_url().is_valid() &&

[Justin Donnelly, 2016/06/21 15:04:54]

This is a complicated bit of code that's difficult to read inline. Maybe use a
function to do this? So each case instead looks like:

AutofillMetrics::LogCardUploadDecisionMetric(
    AutofillMetrics::UPLOAD_NOT_OFFERED_NO_CVC);
CollectRapportSample(submitted_form.source_url(),
    "Autofill.CardUploadNotOfferedNoCvc");

or maybe the function does both?

ReportFailureCase(
    AutofillMetrics::UPLOAD_NOT_OFFERED_NO_CVC,
    "Autofill.CardUploadNotOfferedNoCvc",
    submitted_form.source_url());

[Mathieu, 2016/06/21 17:05:08]

Sure, I prefer the first version.

+          client_->GetRapporService()) {
+        rappor::SampleDomainAndRegistryFromGURL(
+            client_->GetRapporService(), "Autofill.CardUploadNotOfferedNoCvc",
+            submitted_form.source_url());
+      }
       return;
     }
 
     // Upload also requires recently used or modified addresses that meet the
     // client-side validation rules.
     if (!GetProfilesForCreditCardUpload(*imported_credit_card,
-                                        &upload_request_.profiles)) {
+                                        &upload_request_.profiles,
+                                        submitted_form.source_url())) {
       return;
     }
 
     // All required data is available, start the upload process.
     payments_client_->GetUploadDetails(app_locale_);
   }
 }
 
 bool AutofillManager::GetProfilesForCreditCardUpload(
     const CreditCard& card,
-    std::vector<AutofillProfile>* profiles) const {
+    std::vector<AutofillProfile>* profiles,
+    const GURL& source_url) const {
   std::vector<AutofillProfile> candidate_profiles;
   const base::Time now = base::Time::Now();
   const base::TimeDelta fifteen_minutes = base::TimeDelta::FromMinutes(15);
 
   // First, collect all of the addresses used recently.
   for (AutofillProfile* profile : personal_data_->GetProfiles()) {
     if ((now - profile->use_date()) < fifteen_minutes ||
         (now - profile->modification_date()) < fifteen_minutes) {
       candidate_profiles.push_back(*profile);
     }
   }
   if (candidate_profiles.empty()) {
     AutofillMetrics::LogCardUploadDecisionMetric(
         AutofillMetrics::UPLOAD_NOT_OFFERED_NO_ADDRESS);
+    if (source_url.is_valid() && client_->GetRapporService()) {
+      rappor::SampleDomainAndRegistryFromGURL(
+          client_->GetRapporService(), "Autofill.CardUploadNotOfferedNoAddress",
+          source_url);
+    }
     return false;
   }
 
   // If any of the names on the card or the addresses don't match (where
   // matching is case insensitive and ignores middle initials if present), the
   // candidate set is invalid. This matches the rules for name matching applied
   // server-side by Google Payments and ensures that we don't send upload
   // requests that are guaranteed to fail.
   base::string16 verified_name;
   base::string16 card_name =
       card.GetInfo(AutofillType(CREDIT_CARD_NAME_FULL), app_locale_);
   if (!card_name.empty()) {
     verified_name = RemoveMiddleInitial(card_name);
   }
   for (const AutofillProfile& profile : candidate_profiles) {
     base::string16 address_name =
         profile.GetInfo(AutofillType(NAME_FULL), app_locale_);
     if (!address_name.empty()) {
       if (verified_name.empty()) {
         verified_name = RemoveMiddleInitial(address_name);
       } else {
         // TODO(crbug.com/590307): We only use ASCII case insensitivity here
         // because the feature is launching US-only and middle initials only
         // make sense for Western-style names anyway. As we launch in more
         // countries, we'll need to make the name comparison more sophisticated.
         if (!base::EqualsCaseInsensitiveASCII(
                 verified_name, RemoveMiddleInitial(address_name))) {
           AutofillMetrics::LogCardUploadDecisionMetric(
               AutofillMetrics::UPLOAD_NOT_OFFERED_CONFLICTING_NAMES);
+          if (source_url.is_valid() && client_->GetRapporService()) {
+            rappor::SampleDomainAndRegistryFromGURL(
+                client_->GetRapporService(),
+                "Autofill.CardUploadNotOfferedConflictingNames", source_url);
+          }
           return false;
         }
       }
     }
   }
   // If neither the card nor any of the addresses have a name associated with
   // them, the candidate set is invalid.
   if (verified_name.empty()) {
     AutofillMetrics::LogCardUploadDecisionMetric(
         AutofillMetrics::UPLOAD_NOT_OFFERED_NO_NAME);
+    if (source_url.is_valid() && client_->GetRapporService()) {
+      rappor::SampleDomainAndRegistryFromGURL(
+          client_->GetRapporService(), "Autofill.CardUploadNotOfferedNoName",
+          source_url);
+    }
     return false;
   }
 
   // If any of the candidate addresses have a non-empty zip that doesn't match
   // any other non-empty zip, then the candidate set is invalid.
   base::string16 verified_zip;
   for (const AutofillProfile& profile : candidate_profiles) {
     // TODO(jdonnelly): Use GetInfo instead of GetRawInfo once zip codes are
     // canonicalized. See http://crbug.com/587465.
     base::string16 zip = profile.GetRawInfo(ADDRESS_HOME_ZIP);
@@ skipping 839 matching lines @@
     if (i > 0)
       fputs("Next oldest form:\n", file);
   }
   fputs("\n", file);
 
   fclose(file);
 }
 #endif  // ENABLE_FORM_DEBUG_DUMP
 
 }  // namespace autofill