Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2082463002: Measure the usage of navigator.vibrate in for user gesture & subframe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Record more detailed usage of vibrate for user gesture, subframe and cross-origin subframe. Also removing the old metrics. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp ('K') | « third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 68928e41b0bd17fea6c4f6287762d8517ac359c0..39100ad65c18d897e1fa3a6ac61dc5cd647fc38a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -62348,6 +62348,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="WebModules.NavigatorVibrate"
mlamouri (slow - plz ping) 2016/06/27 12:34:03 I wouldn't use a WebModules prefix but instead may
Bin Lu 2016/06/27 15:38:35 Done.
+ enum="NavigatorVibratePermissions">
+ <owner>binlu@google.com</owner>
+ <summary>
+ Records instances of navigator.vibrate. Includes whether or not it comes
+ with a user gesture, same-origin subframe or cross-origin subframe.
+ </summary>
+</histogram>
+
<histogram name="WebRTC.AecDelayBasedQuality" enum="DelayBasedEchoQuality">
<owner>bjornv@chromium.org</owner>
<summary>
@@ -74785,8 +74794,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="847" label="DOMStringList_Item_AttributeGetter_Location"/>
<int value="848" label="DOMStringList_Contains_Method_IndexedDB"/>
<int value="849" label="DOMStringList_Contains_Method_Location"/>
- <int value="850" label="NavigatorVibrate"/>
- <int value="851" label="NavigatorVibrateSubFrame"/>
<int value="852" label="PermissionStatusStatus"/>
<int value="853" label="V8XPathEvaluator_Constructor"/>
<int value="854" label="V8XPathEvaluator_CreateExpression_Method"/>
@@ -82296,6 +82303,15 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="9" label="blob"/>
</enum>
+<enum name="NavigatorVibratePermissions" type="int">
mlamouri (slow - plz ping) 2016/06/27 12:34:02 Not sure if "permissions" is the right term.
Bin Lu 2016/06/27 15:38:35 Done. Changed to "NavigatorVibrationType".
+ <int value="0" label="Main frame vibrate, no user gesture"/>
+ <int value="1" label="Main frame vibrate, user gesture"/>
+ <int value="3" label="Same-origin subframe vibrate, no user gesture"/>
+ <int value="4" label="Same-origin subframe vibrate, user gesture"/>
+ <int value="5" label="Cross-origin subframe vibrate, no user gesture"/>
+ <int value="6" label="Cross-origin subframe vibrate, user gesture"/>
+</enum>
+
<enum name="NetCacheState" type="int">
<int value="0" label="FROM_CACHE"/>
<int value="1" label="STILL_VALID"/>
« third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp ('K') | « third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698